Fix connected_players on_shutdown #14739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #14736
How it works:
Server::~Server()
.(It should be safe, to first stop the ServerThread before kicking the players, as far as I can tell.
As before, the EmergeManager threads are stopped before the on_shutdown callback happens.)
(I'm not sure if I added it at the right place, but it is similar to the
mods/unittests/load_time.lua
file.)To do
This PR is Ready for Review.
How to test
Start devtest and exit devtest.
(The test gets executed every time, similar to what happens in
mods/unittests/load_time.lua
.)