-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better AppStream metadata #14648
Better AppStream metadata #14648
Conversation
I have added a value to display_length. The goal is to make it appear as supported for both PC and mobile devices, so I picked 360 which is the value used by GNOME Calculator. I have also added a tag to display the offline use of Minetest possible. |
I consider this PR as finished, IMO the last TODO item isn't really important. The last thing to check is the contact email, but don't know what to put here obviously. |
ruben and c55 are also listed here: https://github.com/minetest/minetest/security/policy |
@AFCMS updates? |
ACK on appdata/metainfo transition. Look reasonable with requested changes. |
Updated the descriptions to mention the fact that Minetest is a game platform. English and French should be good, for other translations I just used DeepL and can't really validate those. If some people with knowledge of the respective languages could verify the translations that would be great. The last thing that may be done in this PR is the contact email change, but I obviously can't do much about it. |
I guess @celeron55 would be good choice, as @sfan5 pointed https://github.com/minetest/minetest/security/policy |
Updated the contact email to c55 |
I still don't like the short description tbh. It's a lot of words which don't really make sense together.
Minetest is ... what? An infinite-world ... or an infinite-world block sandbox ... or a sandbox game ... or a game platform? Reduced version with more focus:
Also, regarding the German translation:
This highlights the "infinite worlds" aspect too much.
"Blocksandkasten-Spieleplattform"? What's that? |
Co-authored-by: grorp <[email protected]>
Fix #14647
To do
This PR is Ready for Review
.appdata.xml
to.metainfo.xml
(.metainfo.xml is the recommended file name).desktop
.desktop
descriptiongamepadand touch.desktop
file, remove.desktop
from the top id (no idea why it was like that, didn't see it anywhere in the spec)bugtracker
anddonation
How to test
Try running:
or this (less strict):
Warning
With the renaming of the AppStream file, the Flathub manifest will need to be updated to reflect the change I think