Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better AppStream metadata #14648

Merged
merged 12 commits into from
Jul 14, 2024
Merged

Better AppStream metadata #14648

merged 12 commits into from
Jul 14, 2024

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented May 13, 2024

Fix #14647

To do

This PR is Ready for Review

  • Rename .appdata.xml to .metainfo.xml (.metainfo.xml is the recommended file name)
  • Import description translations from .desktop
  • Translate long description in french
  • Fix typo in french .desktop description
  • Use HTTPS URLs for screenshots
  • Add support info for mouse, keyboard, gamepad and touch
  • Add support info for supported screen size
  • Add support info for offline use
  • Use the launchable tag to reference the .desktop file, remove .desktop from the top id (no idea why it was like that, didn't see it anywhere in the spec)
  • Add category and keywords
  • Add basic developer infos (is it OK?)
  • Fix URLs for bugtracker and donation
  • Make first paragraph of long description longer? (>80 characters) Not a big deal IMO.

How to test

Try running:

flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream ./misc/net.minetest.minetest.metainfo.xml

or this (less strict):

appstreamcli validate ./misc/net.minetest.minetest.metainfo.xml

Warning

With the renaming of the AppStream file, the Flathub manifest will need to be updated to reflect the change I think

@AFCMS
Copy link
Contributor Author

AFCMS commented May 13, 2024

I have added a value to display_length.

The goal is to make it appear as supported for both PC and mobile devices, so I picked 360 which is the value used by GNOME Calculator.

I have also added a tag to display the offline use of Minetest possible.

@wsor4035 wsor4035 added @ Startup / Config / Util @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels May 13, 2024
@Zughy Zughy added Action / change needed Code still needs changes (PR) / more information requested (Issues) labels May 13, 2024
@AFCMS AFCMS requested a review from rubenwardy May 14, 2024 07:05
@AFCMS AFCMS mentioned this pull request May 14, 2024
2 tasks
@Zughy Zughy removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label May 14, 2024
@AFCMS
Copy link
Contributor Author

AFCMS commented May 14, 2024

I consider this PR as finished, IMO the last TODO item isn't really important.

The last thing to check is the contact email, but don't know what to put here obviously.

@sfan5
Copy link
Member

sfan5 commented May 20, 2024

ruben and c55 are also listed here: https://github.com/minetest/minetest/security/policy
So one of them would be a good candidate.

@sfan5 sfan5 added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jun 4, 2024
misc/net.minetest.minetest.desktop Outdated Show resolved Hide resolved
@sfan5 sfan5 modified the milestones: 5.10.0, 5.9.0 Jun 16, 2024
@Zughy
Copy link
Member

Zughy commented Jun 30, 2024

@AFCMS updates?

@okias
Copy link
Contributor

okias commented Jun 30, 2024

ACK on appdata/metainfo transition. Look reasonable with requested changes.

@AFCMS
Copy link
Contributor Author

AFCMS commented Jun 30, 2024

Updated the descriptions to mention the fact that Minetest is a game platform.

English and French should be good, for other translations I just used DeepL and can't really validate those.

If some people with knowledge of the respective languages could verify the translations that would be great.

The last thing that may be done in this PR is the contact email change, but I obviously can't do much about it.

@okias
Copy link
Contributor

okias commented Jun 30, 2024

I guess @celeron55 would be good choice, as @sfan5 pointed https://github.com/minetest/minetest/security/policy

@AFCMS
Copy link
Contributor Author

AFCMS commented Jun 30, 2024

Updated the contact email to c55

@Zughy Zughy removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jun 30, 2024
@grorp
Copy link
Member

grorp commented Jul 1, 2024

I still don't like the short description tbh. It's a lot of words which don't really make sense together.

Multiplayer infinite-world block sandbox game platform

Minetest is ... what? An infinite-world ... or an infinite-world block sandbox ... or a sandbox game ... or a game platform? Reduced version with more focus:

Block-based multiplayer game platform

Also, regarding the German translation:

Mehrspieler-Sandkasten-Spielplattform für unendliche Welten

This highlights the "infinite worlds" aspect too much.

Minetest ist eine unendliche Blocksandkasten-Spielplattform.

"Blocksandkasten-Spieleplattform"? What's that?

@AFCMS AFCMS requested review from grorp and nerzhul July 3, 2024 15:50
@AFCMS AFCMS requested a review from grorp July 6, 2024 20:01
@sfan5 sfan5 added One approval ✅ ◻️ 1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f and removed @ Startup / Config / Util labels Jul 14, 2024
@sfan5 sfan5 merged commit 8e59d8b into minetest:master Jul 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Appstream metadata
9 participants