Visual Effects Vol. 1 #14610

GefullteTaubenbrust2 · 2024-05-04T18:23:23Z

This PR is based on #14508 and adds a variety of effects to enhance the visual experience. To this end, it makes changes to shader code, as well as the engine source code, the Lua API and settings.

List of Features and Changes

"soft" clouds look
Tinted shadows
Crude water reflections (sky and sun) and waves
Translucent foliage
Node specular hihlights
Adjusted fog color (more saturated where the fog is lighter)
Minor changes to volumetric lighting (crudely simulates the effect of depth)

Lua API additions

Cloud parameters: shadow field controls the color of the cloud's base
Lighting: tint controls shadow color
- default would be black { r = 0, g = 0, b = 0}
- ambient light from the sky could be emulated by a blue color like { r = 0, g = 50, b = 180 }

Settings

Name	Technical Name	Location	Type	Default
Soft clouds	soft_clouds	Graphics>Clouds	bool	false
Liquid reflections	enable_water_reflections	Shaders>Waving Nodes	bool	false
Translucent Foliage	enable_translucent_foliage	Shaders>Other Effects	bool	false
Node specular	enable_node_specular	Shaders>Other Effects	bool	false

Screenshots

To do

This PR is Ready for Review.

How to test

For most features, simply change the game settings. Of course, the game you use should support dynamic shadows and volumetrics.
The added Lua properties can be used like so:

player:set_clouds({shadow = { r = 120, g = 160, b = 240 }})
player:set_lighting(shadows = { intesity = 0.5, tint = { r = 0, g = 50, b = 180 }})

Revert changes to shadow strength, this probably warrants discussion later. Also, the objects shader was missing this anyway.

Fix bad whitespaces

- "Node reflections" renamed to "node specular" - Fixed goofy artefacts for the foliage effects

lhofhansl · 2024-05-07T15:56:29Z

Tried it, works well. I'll try to find some time in today or tomorrow evening to do a proper review.

Oops

lhofhansl · 2024-05-10T19:44:59Z

Sorry. Very busy work week. Haven't gotten to it, yet.

lhofhansl · 2024-05-11T00:05:42Z

client/shaders/nodes_shader/opengl_fragment.glsl

+}
+
+#if (defined(MATERIAL_WAVING_LIQUID) && defined(ENABLE_WATER_REFLECTIONS)) || defined(ENABLE_BUMPMAPS)
+float snoise(vec3 p)


snoise is not used in this shader as far as I can tell... Only gnoise

True, i think the preprocessor stuff is also not in the right place…

client/shaders/volumetric_light/opengl_fragment.glsl

lhofhansl · 2024-05-11T00:12:18Z

Left two nits... Looks pretty good otherwise.
I'll look at it again in more detail next week, but if folks want to merge this, that'd be OK with me.

lhofhansl · 2024-05-11T00:15:54Z

Flowing water looks a bit weird perhaps, maybe don't do the reflection for flowing water?

tigercoding56 · 2024-05-11T01:23:56Z

Flowing water looks a bit weird perhaps, maybe don't do the reflection for flowing water?

idk i like how it looks, kinda like jello . however maybe some rounding of the corners would be nice (like by interpolating between normals idk i can't glsl)

Wbjitscool · 2024-05-11T02:27:02Z

yeah I like the reflective water too I think it looks good although you can always change it to look a bit different if you don't like it tho

GefullteTaubenbrust2 · 2024-05-11T04:44:50Z

Yeah the water is a bit goofy with slopes… It looks awkward without the reflections, and smoothing the normals isn’t exactly trivial, but I‘ll look into it.

Wbjitscool · 2024-05-11T07:40:46Z

yeah thanks also any ideas for the god rays to have a setting to control the strength of it too

ryvnf · 2024-05-11T22:31:44Z

Can the water reflections be generalized to other nodes? Like having nodes specify (possibly animated) normal maps together with an option to enable it?

tigercoding56 · 2024-05-12T03:26:33Z

Can the water reflections be generalized to other nodes? Like having nodes specify (possibly animated) normal maps together with an option to enable it?

probably out of scope but i like the idea. maybe also a option to specify a cube map (to reflect from) , oh and maybe costum node shaders in lua ? , yeah definitely out of scope.

Wbjitscool · 2024-05-12T05:42:41Z

yeah thanks also any ideas for the god rays to have a setting to control the strength of it too
Yeah tested and works for Mineclonia but VoxeLibre isn't updated to support the sunrays yet anyway

Wbjitscool · 2024-05-12T09:01:51Z

is there a way to fix this problem you place a full block over the water and the water glitches out with shaders on the screenshot doesn't work

tigercoding56 · 2024-05-13T01:41:06Z

is there a way to fix this problem you place a full block over the water and the water glitches out with shaders on the screenshot doesn't work

did you enable waving water by any chance , if so try disabling it (it sometimes does not render water under block correctly)

Wbjitscool · 2024-05-13T02:00:36Z

yep I have waving shaders enabled just disabled it now it renders the water properly but I want the shaders to be on as the liquid shows as a full block and I don't like that I prefer the water to be at least a node below the full block

tigercoding56 · 2024-05-13T23:41:20Z

yep I have waving shaders enabled just disabled it now it renders the water properly but I want the shaders to be on as the liquid shows as a full block and I don't like that I prefer the water to be at least a node below the full block

make a github issue, i think the bug is in water shader as it is a bug even without using GefTau's shader (just with stock minetest)

Wbjitscool · 2024-05-14T01:36:50Z

yeah okay

lhofhansl · 2024-06-02T01:10:28Z

I also think that sky reflection effect could be a little softer (maybe replace the 0.5 factor in the shader with 0.4). This is visible especially at larger viewing distances. But we can change that later if we want to.

Wbjitscool · 2024-06-02T03:06:43Z

sorry about the duped text I had a bit of lag on my end that's why I must of clicked on it a few times for comment not knowing it would post or not

sfan5

first look

builtin/settingtypes.txt

doc/lua_api.md

sfan5 · 2024-06-04T12:19:19Z

doc/lua_api.md

@@ -8401,6 +8403,8 @@ child will follow movement and rotation of that bone.
 * `shadows` is a table that controls ambient shadows
 * `intensity` sets the intensity of the shadows from 0 (no shadows, default) to 1 (blackness)
 * This value has no effect on clients who have the "Dynamic Shadows" shader disabled.
+ * `tint` tints the shadows with the provided color, with RGB values ranging from 0 to 1.


sfan5 · 2024-06-04T12:31:05Z

src/client/clientmap.cpp

+ if (translucent_foliage) {
+ const u32 leaves_shader = m_client->getShaderSource()->getShader("nodes_shader", TILE_MATERIAL_WAVING_LEAVES, NDT_ALLFACES);
+ leaves_material = m_client->getShaderSource()->getShaderInfo(leaves_shader).material;
+ }


I don't have a good suggestion but this looks like totally breaking the abstraction.
Maybe it could be read from a TileLayer of an existing leaf node (NodeDefManager)?

This one I find hard to fix... This is something that isn't so much inherent to the material as it is the shader really, so breaking the abstraction is kind of an inherent thing to the problem unfortunately. I'm open to suggestions but I have no idea how to improve it tbh...

src/client/clouds.cpp

sfan5 · 2024-06-04T12:36:33Z

src/client/clouds.h

@@ -101,6 +101,11 @@ class Clouds : public scene::ISceneNode
 m_params.color_ambient = color_ambient;
 }

+ void setColorShadow(video::SColor color_shadow)
+ {
+ m_params.color_shadow = color_shadow;


missing comparison & mesh invalidation

sfan5 · 2024-06-04T12:44:37Z

src/client/clouds.cpp

+ c_side_2_f.b *= shadow.b * 0.66f + 0.33f;
+ c_bottom_f.r *= shadow.r;
+ c_bottom_f.g *= shadow.g;
+ c_bottom_f.b *= shadow.b;


with the default of 204 this results in 0.92, 0.85, 0.8 (respectively)
which is different than before.

so now I have to ask: where do these magic numbers come from? what is the effect of the change?

src/client/game.cpp

src/network/clientpackethandler.cpp

Co-authored-by: sfan5 <[email protected]>

Also minor changes to fresnel factor

lhofhansl · 2024-06-05T19:32:59Z

Sky reflection looks nicer now. All my nits are resolved.
I maintain my "One Approval"

GefullteTaubenbrust2 · 2024-06-05T19:59:10Z

Oops i think the updateBox() call is redundant… I‘ll fix that soon

DragonWrangler1 · 2024-06-05T20:10:05Z

I compiled this to test it, and wow. This is incredible. Great job

superfloh247 · 2024-06-08T09:42:11Z

very impressive!

MacOS 14, apple silicon M1pro

superfloh247 · 2024-06-11T06:50:56Z

could you please update this branch/PR to latest master?

b7e886a fixes building with LTO (at least for me) and that's a major performance boost (at least for me)

Slightly amplify liquid sun reflections

nerzhul · 2024-06-11T18:41:54Z

clearly an amazing addition, like if it was minetest 2.0 revival, sorry i'll try to review the C++ part, i'm not very nice on shaders.
With a such thing, it can clearly make people adopt more minetest than MC (we are not concurrent) for gameplay (we should work on NPCs !)

Wbjitscool · 2024-06-21T06:37:05Z

I know what else would be awesome to see is that entities like players etc and blocks could also reflect off the water too

GefullteTaubenbrust2 · 2024-06-21T16:03:28Z

I know what else would be awesome to see is that entities like players etc and blocks could also reflect off the water too

There is actually a branch by @GreenXenith that adds screenspace reflections that he is planning to add at some point. It could replace these water reflections.

lhofhansl · 2024-06-22T16:48:33Z

@grorp 's comments were addressed.

src/client/shadows/dynamicshadowsrender.cpp

lhofhansl · 2024-07-03T22:17:19Z

Do we need to wait for 5.10.0 for this? I'm afraid we'll let another good contribution bit-rot.
I've had this applied for almost 8 weeks and have not observed any issues.

Inlined setShadowTint function, fixed issue where third person view or getting close to nodes causes weird artefacts with their specular reflections

Zughy · 2024-07-05T12:05:25Z

Yes, feature freeze applies to everyone

Fix specular intensity not applying

nerzhul · 2024-07-06T15:44:19Z

i'd say, release, and merge just after, let people feedback us on 5.11-dev cycle and go ahead :)

grorp · 2024-07-12T20:45:04Z

I see @lhofhansl removed "Action/change needed", yet #14610 (review) by @sfan5 still has unresolved comments. What happened there?

GefullteTaubenbrust2 · 2024-07-14T15:48:28Z

I see @lhofhansl removed "Action/change needed", yet #14610 (review) by @sfan5 still has unresolved comments. What happened there?

They should all be adressed (except one that I don't know how to improve) they just aren't marked as resolved.

lhofhansl · 2024-07-15T15:09:05Z

@grorp You requested changes and the label, those changes were made so I removed the label. Nothing nefarious here :)
I'm not aware of any requested changes other than @nerzhul's minor request.

Initial commit

90b45cc

wsor4035 added @ Client / Audiovisuals Feature ✨ PRs that add or enhance a feature @ Script API Shaders labels May 4, 2024

wsor4035 assigned lhofhansl and sfan5 May 4, 2024

GefullteTaubenbrust2 added 4 commits May 5, 2024 18:25

Update opengl_vertex.glsl

e38efea

Revert changes to shadow strength, this probably warrants discussion later. Also, the objects shader was missing this anyway.

Update clouds.cpp

dd49ccf

Fix bad whitespaces

Fixes and changes

6a79979

- "Node reflections" renamed to "node specular" - Fixed goofy artefacts for the foliage effects

Update opengl_fragment.glsl

fd3302b

Update defaultsettings.cpp

8c40126

Oops

lhofhansl reviewed May 11, 2024

View reviewed changes

client/shaders/volumetric_light/opengl_fragment.glsl Show resolved Hide resolved

sfan5 reviewed Jun 4, 2024

View reviewed changes

GefullteTaubenbrust2 and others added 2 commits June 5, 2024 13:36

Update src/client/game.cpp

ac6e72a

Co-authored-by: sfan5 <[email protected]>

Apply suggestions

f82cebf

Also minor changes to fresnel factor

Update clouds.h

b4aa026

GefullteTaubenbrust2 added 2 commits June 11, 2024 12:50

Merge remote-tracking branch 'upstream/master' into Visuals-Vol-1

5d53cad

Update opengl_fragment.glsl

8c33728

Slightly amplify liquid sun reflections

appgurueu added this to the 5.10.0 milestone Jun 18, 2024

lhofhansl removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jun 22, 2024

This comment was marked as off-topic.

Sign in to view

nerzhul requested changes Jun 28, 2024

View reviewed changes

src/client/shadows/dynamicshadowsrender.cpp Outdated Show resolved Hide resolved

Minor fixes

b333d00

Inlined setShadowTint function, fixed issue where third person view or getting close to nodes causes weird artefacts with their specular reflections

Update opengl_fragment.glsl

a1a1652

Fix specular intensity not applying

superfloh247 mentioned this pull request Jul 7, 2024

[Adoption] of GreenXenith's bfs shaders. #14828

Draft

Visual Effects Vol. 1 #14610

Are you sure you want to change the base?

Visual Effects Vol. 1 #14610

Conversation

GefullteTaubenbrust2 commented May 4, 2024 • edited Loading

Lua API additions

Settings

To do

How to test

lhofhansl commented May 7, 2024

lhofhansl commented May 10, 2024

lhofhansl May 11, 2024

Choose a reason for hiding this comment

GefullteTaubenbrust2 May 11, 2024

Choose a reason for hiding this comment

lhofhansl commented May 11, 2024

lhofhansl commented May 11, 2024

tigercoding56 commented May 11, 2024 • edited Loading

Wbjitscool commented May 11, 2024 • edited Loading

GefullteTaubenbrust2 commented May 11, 2024

Wbjitscool commented May 11, 2024 • edited Loading

ryvnf commented May 11, 2024 • edited Loading

tigercoding56 commented May 12, 2024 • edited Loading

Wbjitscool commented May 12, 2024

Wbjitscool commented May 12, 2024 • edited Loading

tigercoding56 commented May 13, 2024

Wbjitscool commented May 13, 2024 • edited Loading

tigercoding56 commented May 13, 2024 • edited Loading

Wbjitscool commented May 14, 2024

lhofhansl commented Jun 2, 2024

Wbjitscool commented Jun 2, 2024

sfan5 left a comment

Choose a reason for hiding this comment

sfan5 Jun 4, 2024

Choose a reason for hiding this comment

sfan5 Jun 4, 2024

Choose a reason for hiding this comment

GefullteTaubenbrust2 Jun 5, 2024

Choose a reason for hiding this comment

sfan5 Jun 4, 2024

Choose a reason for hiding this comment

sfan5 Jun 4, 2024

Choose a reason for hiding this comment

lhofhansl commented Jun 5, 2024

GefullteTaubenbrust2 commented Jun 5, 2024 • edited Loading

DragonWrangler1 commented Jun 5, 2024 • edited Loading

superfloh247 commented Jun 8, 2024 • edited Loading

superfloh247 commented Jun 11, 2024

nerzhul commented Jun 11, 2024

Wbjitscool commented Jun 21, 2024 • edited Loading

GefullteTaubenbrust2 commented Jun 21, 2024

lhofhansl commented Jun 22, 2024 • edited Loading

This comment was marked as off-topic.

lhofhansl commented Jul 3, 2024 • edited Loading

Zughy commented Jul 5, 2024

nerzhul commented Jul 6, 2024

grorp commented Jul 12, 2024

GefullteTaubenbrust2 commented Jul 14, 2024

lhofhansl commented Jul 15, 2024 • edited Loading

GefullteTaubenbrust2 commented May 4, 2024 •

edited

Loading

tigercoding56 commented May 11, 2024 •

edited

Loading

Wbjitscool commented May 11, 2024 •

edited

Loading

Wbjitscool commented May 11, 2024 •

edited

Loading

ryvnf commented May 11, 2024 •

edited

Loading

tigercoding56 commented May 12, 2024 •

edited

Loading

Wbjitscool commented May 12, 2024 •

edited

Loading

Wbjitscool commented May 13, 2024 •

edited

Loading

tigercoding56 commented May 13, 2024 •

edited

Loading

GefullteTaubenbrust2 commented Jun 5, 2024 •

edited

Loading

DragonWrangler1 commented Jun 5, 2024 •

edited

Loading

superfloh247 commented Jun 8, 2024 •

edited

Loading

Wbjitscool commented Jun 21, 2024 •

edited

Loading

lhofhansl commented Jun 22, 2024 •

edited

Loading

lhofhansl commented Jul 3, 2024 •

edited

Loading

lhofhansl commented Jul 15, 2024 •

edited

Loading