Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow list improvements #12898

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Shadow list improvements #12898

merged 2 commits into from
Oct 26, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented Oct 24, 2022

Fixes #12877 and avoids a memory leak when wield mesh changes item stacks.

To do

This PR is Ready for Review.

How to test

  1. Enable dynamic_shadows mod in a game with entities e.g. RePixture
  2. Enter the world
  3. Find animals
  4. /shadow_intensity 0
  5. /shadow_intensity 0.5
  6. Flip between 4. and 5. a few times.
  7. There should be no error messages from Irrlicht and no crash.

@x2048
Remove redundant checks when attaching SM texture to entities.
2f41188 
Some of the checks were broken, leading to crashes when shadow intensity is set to 0
@x2048
Avoid memory leak in shadow casters list when wield mesh changes item…
0abfd35 
… stacks
@x2048 x2048 requested a review from lhofhansl October 24, 2022 23:30
@x2048 x2048 added this to the 5.7.0 milestone Oct 24, 2022
lhofhansl
lhofhansl approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@lhofhansl lhofhansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@x2048 x2048 merged commit 88820cd into minetest:master Oct 26, 2022
@x2048 x2048 deleted the shadow_list branch October 26, 2022 22:00
LoneWolfHT pushed a commit to LoneWolfHT/minetest that referenced this pull request Nov 1, 2022
@x2048 @LoneWolfHT
Shadow list improvements (minetest#12898)
93736e5 
* Remove redundant checks when attaching SM texture to entities.
  Some of the checks were broken, leading to crashes when shadow intensity is set to 0
* Avoid memory leak in shadow casters list when wield mesh changes item stacks
@lhofhansl lhofhansl mentioned this pull request Nov 24, 2022
Merged
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
@x2048 @appgurueu
Shadow list improvements (minetest#12898)
d1ca12e 
* Remove redundant checks when attaching SM texture to entities.
  Some of the checks were broken, leading to crashes when shadow intensity is set to 0
* Avoid memory leak in shadow casters list when wield mesh changes item stacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhofhansl lhofhansl lhofhansl approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals >= Two approvals ✅ ✅
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Crash when shadow intensity is set to 0
2 participants
@x2048 @lhofhansl