Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bloom shaders compatible with GLES2 #12834

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Make bloom shaders compatible with GLES2 #12834

merged 1 commit into from
Oct 4, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented Oct 4, 2022

Fixes #12824

To do

This PR is Ready for Review.

How to test

  1. Play Minetest on GLES 2.0
  2. The game should render normally, without shader errors.

Co-authored-by: @srifqi

@x2048 @srifqi
Make bloom shaders compatible with GLES2
013e8f4 
Co-Authored-By: Muhammad Rifqi Priyo Susanto <[email protected]>
@x2048 x2048 self-assigned this Oct 4, 2022
@x2048 x2048 added @ Client / Audiovisuals Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Oct 4, 2022
sfan5
sfan5 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenwardy rubenwardy merged commit 579fc93 into minetest:master Oct 4, 2022
@x2048 x2048 deleted the bloom_gles branch November 3, 2022 16:26
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
@x2048 @srifqi @appgurueu
Make bloom shaders compatible with GLES2 (minetest#12834)
acbfc0c 
Co-authored-by: Muhammad Rifqi Priyo Susanto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees

@x2048 x2048

Labels
Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shaders won't compile on OpenGL ES 2.0+ after #12791
3 participants
@x2048 @sfan5 @rubenwardy