Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTest: Change texture for node-aligned node #12831

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Oct 3, 2022

Fixes #12559.

@Wuzzy2 Wuzzy2 added @ Devtest Game Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Oct 3, 2022
@rubenwardy
Copy link
Member

Missing license.txt update

@sfan5 sfan5 added Bugfix 🐛 PRs that fix a bug and removed Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Oct 4, 2022
Copy link
Contributor

@TurkeyMcMac TurkeyMcMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the missing license notice.

@TurkeyMcMac TurkeyMcMac added >= Two approvals ✅ ✅ Action / change needed Code still needs changes (PR) / more information requested (Issues) and removed One approval ✅ ◻️ labels Oct 4, 2022
@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Oct 4, 2022

Tbh, I don't think most images in DevTest even apply to copyright in the first place because they're trivial, especially those test nodes. There is a bunch of other textures in DevTest that I have created when I made the big DevTest rework. If you still want this to be documented, please say so and I make a separate PR for all these files at once.

@TurkeyMcMac TurkeyMcMac removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Oct 4, 2022
@TurkeyMcMac
Copy link
Contributor

Your choice.

@rubenwardy
Copy link
Member

rubenwardy commented Oct 6, 2022

If you still want this to be documented, please say so and I make a separate PR for all these files at once.

Technically you should do, as the default license for Minetest is CC BY-SA requires attribution and it's hard to do that without knowledge of where the textures come from. But as you say, that doesn't matter for this PR

@rubenwardy rubenwardy merged commit 804a318 into minetest:master Oct 6, 2022
@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Oct 6, 2022

So is this an official request to create a 2nd PR or not?
But be warned: It will be a LONG list of files and all DevTest images I made were hastily scribbled together in seconds, those aren't works of art.

@rubenwardy
Copy link
Member

I wouldn't worry about it unless someone complains. Maybe at most you could add a line like "Unless otherwise stated, devtest textures are by Wuzzy" but idk

appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devtest tiled:tiled_n texture is misleading
4 participants