Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTest: Reject buggy "/hp inf" command #12830

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Oct 3, 2022

Fixes #11817.

This will reject invalid arguments for the hp command like inf or numbers out of range.

@Wuzzy2 Wuzzy2 added @ Devtest Game Bugfix 🐛 PRs that fix a bug labels Oct 3, 2022
@sfan5 sfan5 added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Oct 3, 2022
Copy link
Contributor

@TurkeyMcMac TurkeyMcMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TurkeyMcMac TurkeyMcMac merged commit b10d654 into minetest:master Oct 3, 2022
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Devtest Game One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signed integer overflow if doing /hp inf in devtest
3 participants