Fix inconsistent craft replacements (#9250)

[Wuzzy2]

Fixes #9250.

How to test:

Use this recipe in MTG:

minetest.register_craft({
	type = "shaped",
	recipe = {
		{"group:leaves", "default:apple"},
		{"default:apple", "group:leaves"},
	},
	output = "default:dirt",
	replacements = {
		{"group:leaves", "default:sapling"},
	},
})

Craft this recipe.
One time craft it with exactly 1 of each of the 4 recipe input slots in the grid.
The other time, craft it with exactly 2 of each recipe input slots in the grid.

Both times, you should get 1 dirt as regular output plus 1 sapling.
In the first time, the sapling appears in the crafting grid.
In the second time, the sapling appears in your inventory instead.

(The bug was that in the second time, you might end up with 2 instead of 1 sapling, depending on the stack sizes of your input items.)

Shoutout to @p-ouellette!

[TurkeyMcMac]

Works.

[Wuzzy2]

So I'm not going to change this PR because of the break statements, until a maintainer says otherwise (and it's still functional).

[fluxionary]

There's still a bug somewhere.

use this recipe:

minetest.register_craft({
    type = "shapeless",
    output = "default:tree",
    recipe = {"default:wood", "default:wood", "default:stick", "default:stick"},
    replacements = {
        {"default:wood", "default:coal_lump"},
        {"default:wood", "default:coal_lump"},
        {"default:stick", "default:stick"},
    },
})

expected results after crafting w/ stacks of count 2 in the crafting grid, crafting a single item:

• get 1 default:tree
• get 2 default:coal_lump in main inventory
• get 1 default:stick in main inventory
• crafting grid still contains 2 stacks of 1 default:wood and 2 stacks of 1 default:stick.

however, you will end up w/ 2 default:stick in main inventory instead of 1 (everything else as expected).

things still work as expected when the grid would be empty afterwards.

[TurkeyMcMac]

I can't reproduce your issue.

[fluxionary]

I can't reproduce your issue.

you're right, i was running the test in the wrong window. everything works fine now.