Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise bump_version.sh script to address shortcomings #12789

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Sep 20, 2022

fixes #12645 (both mentioned problems)

Note: when testing this cherry pick the commit into a clone of the Minetest repo, it may not work in forks.

@sfan5 sfan5 added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Sep 20, 2022
Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I haven't tested

@sfan5 sfan5 merged commit 9f0d884 into minetest:master Oct 21, 2022
@sfan5 sfan5 deleted the bumpscript branch October 21, 2022 15:11
LoneWolfHT pushed a commit to LoneWolfHT/minetest that referenced this pull request Nov 1, 2022
nerzhul pushed a commit to nerzhul/minetest that referenced this pull request Nov 3, 2022
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add big red warning to bump_release.sh to check protocol version has been updated
2 participants