Mainmenu: Properly sort mods and games #12758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes trivial and unused pkgmgr functions Fixes a bug caused by sorting in 2133fc8
SmallJoker
added
Maintenance
sfan5
reviewed
Sep 11, 2022
sfan5
reviewed
Sep 11, 2022
rubenwardy
reviewed
Sep 11, 2022
| --- Scans a directory recursively for mods and adds them to `listing` | ||
| -- @param path Absolute directory path to scan recursively | ||
| -- @param virtual_path Prettified unique path (e.g. "mods", "mods/mt_modpack") | ||
| -- @param listing Input. Flat array to insert located mods and modpacks |
There was a problem hiding this comment.
Shouldn't "Input" be "Output"?
There was a problem hiding this comment.
Yes and no. It's a mandatory table input which is then modified by reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes trivial and unused pkgmgr functions
Fixes a bug caused by sorting in 2133fc8
To do
This PR is Ready for Review.
How to test
Bonus: The mods are now also sorted in the Settings tab.