Fix texture pack sorting in content tab #12727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Aug 27, 2022
SmallJoker
added
the
Trivial
|
Is there are change needed here? |
|
If a texture pack doesn't have a title, what's the value of .title? Make sure it's the name and not the empty string or nil |
|
@rubenwardy Titles default to the texture pack directory name in that case. I will also sort the game listing to have the content tab consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the content tab, games and mods are sorted in alphabetical order. However, texture packs are sorted in reverse order. This PR fixes that by reversing the order that texture packs are sorted.
To do
This PR is Ready for Review.
How to test
See that texture packs are now sorted properly.