Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package title to ContentDB error messages #12705

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

rubenwardy
Copy link
Member

Fixes #12671

To do

This PR is a Ready for Review.

How to test

Load CDB, turn off internet, and click install

@rubenwardy rubenwardy added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines @ Mainmenu @ Content / PkgMgr labels Aug 15, 2022
@rubenwardy rubenwardy changed the title Add game title and author to ContentDB error messages Add package title to ContentDB error messages Aug 15, 2022
@rubenwardy rubenwardy force-pushed the cdb-pkg-name-in-errors branch 4 times, most recently from 60f114c to 755be8f Compare August 15, 2022 20:34
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenwardy rubenwardy merged commit c4ffe63 into minetest:master Aug 16, 2022
@rubenwardy rubenwardy deleted the cdb-pkg-name-in-errors branch August 16, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Content / PkgMgr @ Mainmenu One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentDB async errors should state the package involved
3 participants