Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enable x86 build for Android #12700

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Fix and enable x86 build for Android #12700

merged 2 commits into from
Aug 25, 2022

Conversation

savilli
Copy link
Contributor

@savilli savilli commented Aug 14, 2022

See minetest/minetest_android_deps#2. Should be merged after that PR.

Fixes #11744

@Zughy Zughy added @ Build CMake, build scripts, official builds, compiler and linker errors Android Bugfix 🐛 PRs that fix a bug labels Aug 14, 2022
@rollerozxa
Copy link
Member

Should the x86 APK be split as well with a different version code like the armeabi-v7a and arm64 versions are currently?

@sfan5
Copy link
Member

sfan5 commented Aug 14, 2022

A word of caution: it will be impossible to upload the x86 build to the playstore without also providing a x86_64 build, since the requirement also applies here.

@savilli
Copy link
Contributor Author

savilli commented Aug 14, 2022

A word of caution: it will be impossible to upload the x86 build to the playstore without also providing a x86_64 build, since the requirement also applies here.

A good point. Enabled x86_64 build as well.

@sfan5
Copy link
Member

sfan5 commented Aug 14, 2022

Well I think we're fine with just x86 and people who have one of these rare devices can download the right build from Github but 🤷

@savilli
Copy link
Contributor Author

savilli commented Aug 14, 2022

I think it won't be excessive.

@rubenwardy
Copy link
Member

Should the x86 APK be split as well with a different version code like the armeabi-v7a and arm64 versions are currently?

It would be nice to be able to have one version code for all the variants. I upload the app to play using an app bundle already, so it might be possible

rubenwardy
rubenwardy previously approved these changes Aug 25, 2022
@rubenwardy
Copy link
Member

You forgot to enable x86 and x86_64 in android/native/build.gradle

@savilli
Copy link
Contributor Author

savilli commented Aug 25, 2022

You forgot to enable x86 and x86_64 in android/native/build.gradle

Where?

@rubenwardy
Copy link
Member

rubenwardy commented Aug 25, 2022

In a x86_64 Android 13 emulator. Could just be an emulator graphics acceleration issue, I don't have a x86 device

image

@rubenwardy
Copy link
Member

Where?

Nevermind, looks like Android Studio was caching the old version

@savilli
Copy link
Contributor Author

savilli commented Aug 25, 2022

In a x86_64 Android 13 emulator. Could just be an emulator graphics acceleration issue, I don't have a x86 device

Looks like it's out of GPU memory, try to increase it.

@rubenwardy
Copy link
Member

Looks like it's out of GPU memory, try to increase it.

Any idea how to do that? There's only options for RAM and storage

image

@rubenwardy
Copy link
Member

rubenwardy commented Aug 25, 2022

If someone can test this on an actual x86 device and it works then I'm happy

@savilli
Copy link
Contributor Author

savilli commented Aug 25, 2022

Looks like it's out of GPU memory, try to increase it.

Any idea how to do that? There's only options for RAM and storage

No idea, I've managed to run it without graphic issues with an image from https://www.android-x86.org/ and a long qemu command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Bugfix 🐛 PRs that fix a bug @ Build CMake, build scripts, official builds, compiler and linker errors >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android apk x86 build
5 participants