-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and enable x86 build for Android #12700
Conversation
Should the x86 APK be split as well with a different version code like the armeabi-v7a and arm64 versions are currently? |
A word of caution: it will be impossible to upload the x86 build to the playstore without also providing a x86_64 build, since the requirement also applies here. |
A good point. Enabled x86_64 build as well. |
Well I think we're fine with just x86 and people who have one of these rare devices can download the right build from Github but 🤷 |
I think it won't be excessive. |
It would be nice to be able to have one version code for all the variants. I upload the app to play using an app bundle already, so it might be possible |
You forgot to enable x86 and x86_64 in android/native/build.gradle |
Where? |
Nevermind, looks like Android Studio was caching the old version |
Looks like it's out of GPU memory, try to increase it. |
If someone can test this on an actual x86 device and it works then I'm happy |
No idea, I've managed to run it without graphic issues with an image from https://www.android-x86.org/ and a long qemu command. |
See minetest/minetest_android_deps#2. Should be merged after that PR.
Fixes #11744