Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassure previous nil behaviour for tiles and special_tiles #12678

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Aug 9, 2022

Alternative approach to #12659 . See comments in there

To do

This PR is Ready for Review.

@Zughy Zughy added Bugfix 🐛 PRs that fix a bug @ Builtin Regression Something that used to work no longer does. labels Aug 9, 2022
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of consistency with the other nil item table values, I prefer this PR over the other.

LGTM

@Zughy Zughy added this to the 5.6.1 milestone Aug 13, 2022
@rubenwardy rubenwardy merged commit 3132efc into minetest:master Aug 13, 2022
sfan5 pushed a commit that referenced this pull request Sep 14, 2022
@Zughy Zughy deleted the nil_tiles branch July 31, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Builtin Regression Something that used to work no longer does. >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants