Fix media overriding regression #12602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have a test for this in src/unittest/test_servermodmanager.cpp |
|
I agree. If this has been broken twice, it should be tested in an automatic fashion. Also, this commit is missing manual testing instructions. Just look at devtest and see that there are no error textures on the side of grass blocks? |
Currently working on it (paths are a bit messy though; I suppose I'll go find the relevant paths using RegEx endswith).
See the linked issue (yes). |
5b88358
to
5892fcf
Compare
rubenwardy
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12557. Ruben replaced a reverse iterator (
crbegin&crend) with a normal one. Reverted that and added a comment since this is a reregression (the second time mod media overriding was broken) so that this doesn't happen again.