Physics overrides: Move values to a common struct #12591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code tidy. This moves all physics overrides to a dedicated struct.
sfan5
reviewed
Aug 7, 2022
Co-authored-by: sfan5 <[email protected]>
rubenwardy
approved these changes
Aug 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code tidy. This moves all physics overrides to a dedicated struct.
This is to avoid further chaos before #11465 gets merged. A server-sided physics modifier API (#10731) could still be built on top of these changes by recycling this struct.
To do
This PR is Ready for Review.
How to test