Fix rotation of falling facedir nodes in some cases #12587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotation of falling facedir nodes with
param2
values of e.g. 255 and 24-31 is incorrect.The engine calculates the facedir value by doing
param2 % 32 % 24
. The falling node code that calculates the facedir value only doesparam2 % 32
and doesn't rotate nodes whereparam2 % 32 > 23
at all.The relevant code in
MapNode::getFaceDir
:minetest/src/mapnode.cpp
Line 151 in 2351c95
and in
falling.lua
:minetest/builtin/game/falling.lua
Lines 161 to 166 in 2351c95
This PR changes
falling.lua
to calculate the facedir value in the same way as the engine. It also adds a test node to Devtest,testnodes:falling_facedir
.To do
This PR is Ready for Review.
How to test
In Devtest, place a
testnodes:falling_facedir
node and set itsparam2
to 255. See that it is rotated incorrectly while falling without the changes tofalling.lua
and correctly with them.