Fix regression & replace more occurrences of vector.new with vector.copy

[appgurueu]

Fixes #12537. vector.new(nil) is the null vector (deprecated). I missed this possibility when replacing vector.new with vector.copy: Pointed things may be entities.

[sfan5]

Add a regression test?
(Alternatively you can view it not as a regression test but as increasing the test coverage of our API, of which there is basically none).

[appgurueu]

Add a regression test?

For a local function? This is used as a helper for in-game stuff, I don't see how testing it would be feasible.

[sfan5]

For minetest.punch_node

[appgurueu]

For minetest.punch_node

Do we have a decent framework for multiplayer tests?

[sfan5]

Have you looked into games/devtest/mods/unittests recently?

[appgurueu]

Have you looked into games/devtest/mods/unittests recently?

No, thanks for pointing me to that. Are these locations documented somewhere?

[sfan5]

No, this would fit well into a wiki page documenting our source structure but we don't have one.

[sfan5]

Uh wait, the test is failing. That means punch_node doesn't do what lua_api.txt promises.

You can comment it out for now, that's for another PR/time.

[appgurueu]

Uh wait, the test is failing. That means punch_node doesn't do what lua_api.txt promises.

You can comment it out for now, that's for another PR/time.

Nah, it was punching an air node (my bad). The server correctly discarded that. Registered a test node to punch.

[appgurueu]

Fixed whatever grep -rE "vector\.new\([^\,]*\)" found (minus the false-positives and tests in vector_spec.lua).

[sfan5]

🏝️

[sfan5]

Why did the unittest that was added here fail again?

[appgurueu]

Not sure. You might find something in the IRC logs.

[sfan5]

https://irc.minetest.net/minetest-dev/2022-07-14#i_5994326

17:12 	sfan5 	one reason could be that the map is not loaded but that'd be a major fail of the test framework
17:12 		have fun debugging this

🤷