Optimize strict.lua #12495
Merged
Optimize strict.lua #12495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
commented
Jun 30, 2022
builtin/common/strict.lua
Outdated
| core.log("warning", ("Undeclared global variable %q accessed at %s:%s") | ||
| :format(name, info.short_src, info.currentline)) | ||
| warned[warn_key] = true | ||
| end | ||
| return rawget(self, name) | ||
| return nil |
There was a problem hiding this comment.
__index is only called if the value is nil, so there's no need to rawget here
Zughy
added
Maintenance
sfan5
reviewed
Jun 30, 2022
sfan5
reviewed
Jun 30, 2022
Co-authored-by: sfan5 <[email protected]>
appgurueu
commented
Jun 30, 2022
sfan5
approved these changes
Jun 30, 2022
rubenwardy
approved these changes
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some basic optimizations.
How to test
Expected: One warning for
undeclared1and one forundeclared2.