Sounds: Various little improvements #12486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SimpleSoundSpec where reasonable (OpenAL) Ensure the sound IDs do not underflow or get overwritten -> loop in u16 Proper use of an enum.
SmallJoker
added
the
Maintenance
rubenwardy
approved these changes
Jul 2, 2022
src/client/sound_openal.cpp
Outdated
| @@ -379,6 +377,23 @@ class OpenALSoundManager: public ISoundManager | |||
| infostream << "Audio: Deinitialized." << std::endl; | |||
| } | |||
|
|
|||
| u16 getFreeId() const | |||
| { | |||
| static thread_local u16 last_used_id = 0; | |||
There was a problem hiding this comment.
why a static thread_local? This feels more like a class member thing
There was a problem hiding this comment.
Recycled 1:1 from activeobjectmgr.h
EDIT: Like ActiveObjectMgr, this is a singleton, hence isolating the variable in this function will work as expected and not clutter the class members.
There was a problem hiding this comment.
Hmm, I think using class members is less of a code small, but I'm not too bothered about it.
|
Oops, clicked the wrong button. Looks good apart from that though |
rubenwardy
added
Action / change needed
rubenwardy
approved these changes
Jul 2, 2022
rubenwardy
added
One approval ✅ ◻️
and removed
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy; this turned out to be a minor code move/tidy.
To do
This PR is Ready for Review.
How to test