Remove workaround for normals not matching winding order #12460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Jul 2, 2022
|
Is the cube supposed to look like this? The shading looks correct now, hence I assume that's the bugfix? PR: master: |
That's definitely an improvement. The cube is actually supposed to look like a full cube. Looks like backface culling still determines normals based on winding order... Either way this is low-priority for me as I've just made the winding order of my faces match the normals. |
SmallJoker
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12430.
After this, correct shading of entities requires correct or zero normals in the models. There is a related fix for the B3D exporter for Blender: GreenXenith/io_scene_b3d#7.
To do
This PR is Ready for Review.
How to test
Use the test from #12430.
@appgurueu