Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing item alias metatables to async environment #12458

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Jun 19, 2022

originals:

local alias_metatable = {
__index = function(t, name)
return rawget(t, core.registered_aliases[name])
end
}
setmetatable(core.registered_items, alias_metatable)
setmetatable(core.registered_nodes, alias_metatable)
setmetatable(core.registered_craftitems, alias_metatable)
setmetatable(core.registered_tools, alias_metatable)

and
-- Disable all further modifications
getmetatable(itemdef).__newindex = {}

To do

This PR is Ready for Review.

How to test

  • observe CI

@sfan5 sfan5 added @ Script API Bugfix 🐛 PRs that fix a bug labels Jun 19, 2022
@sfan5 sfan5 added this to the 5.6.0 milestone Jun 23, 2022
@sfan5 sfan5 merged commit fc34604 into minetest:master Jul 3, 2022
@sfan5 sfan5 deleted the asyncmiss branch July 3, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants