Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tile_images and special_materials obsolete code #12455

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Jun 19, 2022

Git blaming has brought me here fd1135c

To do

This PR is Ready for Review.

How to test

Go back in time and be sure it was Celeron the one who wrote those lines

@Zughy Zughy added @ Documentation Improvements or additions to documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Jun 19, 2022
@SmallJoker
Copy link
Member

There's also code on C++ side. What's going to happen with that? Exist forever?

@Zughy
Copy link
Member Author

Zughy commented Jun 19, 2022

Silly me, removed it

builtin/game/item.lua Outdated Show resolved Hide resolved
@sfan5 sfan5 changed the title Docs: remove 10 year old deprecated annotations Remove tile_images and special_materials compatibility code (10 years old) Jun 19, 2022
@sfan5 sfan5 added @ Script API and removed Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Jun 19, 2022
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@appgurueu
Copy link
Contributor

Yay! The code base is now 0.01% cleaner /s.

@rubenwardy rubenwardy changed the title Remove tile_images and special_materials compatibility code (10 years old) Remove tile_images and special_materials obsolete code Jun 27, 2022
@rubenwardy rubenwardy merged commit 18fbc03 into minetest:master Jun 27, 2022
@Zughy Zughy deleted the trivial_doc branch August 9, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation Improvements or additions to documentation @ Script API >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants