Lua API: Refer to the update_translations tool #12419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
added
@ Documentation
|
I had no idea this was a thing and I was actually thinking about writing one myself. This definitely spares me a lot of time, thanks! |
|
Please import the script into Minetest directly. It doesn't make sense to keep this one external. I've used this script all the time for my translation efforts. But please review this script to spot problems/mistakes before merging. |
sfan5
reviewed
Jun 13, 2022
|
+1 with sfan5's change |
MY HANDS ARE TYPING WORDS HAAAAAAAAAANDS Co-authored-by: sfan5 <[email protected]>
rubenwardy
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is at least the third time I asked for the translation tool. Writing translation files manually is insane, hence the motivation for a well-established script to automatize the process.
minetest-toolsis not well known, hence a link in the relevant Lua API section makes totally sense.I opened this PR to discuss whether to refer to the repository or to import the script into
utilsdirectly.To do
This PR is ready for discussion/review.