Docs: add "flip moon texture" into breakage file

[Zughy]

As someone who both makes art and develop, the flipped moon still annoys me (yes, it is flipped if you've had to document it #11940). Considering the "controversial" tag in #11902, this should be an approach that makes everyone happy in the long run

To do

This PR is Ready for Review.

How to test

read

[appgurueu]

yes, it is flipped if you've had to document it

This argument is moot. We would've had to document the orientation being the same as the sun's as well. To add to the never-ending chain of analogies: Consider XYZW vs WXYZ quaternion order. You have to document which one it is. You can't just say "because we've had to document XYZW we should WXYZ instead because it's obvious". IMO neither orientation is "obvious" or "more intuitive". Both would have to be documented.

[erlehmann]

Considering the "controversial" tag in #11902, this should be an approach that makes everyone happy in the long run

Nope.

First, breaking every mod that actually cares about moon rotation does not magically become a good thing if documented.

Second, only you seem to think there is a “right” way up. Rotation is pretty much arbitrary; not breaking things is preferable.

Third, you already tried this once in #11902 and it was extensively discussed and ultimaltely rejected. So please cut the crap.

[Zughy]

Second, only you seem to think there is a “right” way up.

For the rest of what he's said, I leave to the reader the pain to go through the PR both he and I mentioned, which it ended with "I think compatibility is most important here.", hence my 6.0 breaking suggestion

[appgurueu]

Second, only you seem to think there is a “right” way up.

Oh so we're going with popularity here? Guess what:

[corarona]

once you have broken everything at least one time, will you consider making the world larger ? :(

[rubenwardy]

Yes, that should be added to this file

Please note that this file is not binding, it's notes about things to consider when doing 6.0. I don't think the moon direction is important, either convention is fine, I just don't want to spend any more time talking about it

[appgurueu]

I don't think the moon direction is important, either convention is fine, I just don't want to spend any more time talking about it

Then close this PR. Simplest way to go about it: No (breaking) change is needed.

\o/

[rubenwardy]

If anyone cares about this when we get to 6.0 then we can have the discussion then. I cba to go through this discussion again for such a tiny issue

[rubenwardy]

Actually, I'll just unsubscribe from this thread

[celeron55]

I would be fine either way, so if any core dev wants this in I give them my approval.

[sfan5]

<+sfan5> it will be reassesed anyway when the time actually comes so we can just add it to the file