Optimize misc helpers #12377
Merged
Optimize misc helpers #12377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
force-pushed
the
opt-misc-helpers
branch
2 times, most recently
from
75769c1
to
eb156de
Compare
appgurueu
force-pushed
the
opt-misc-helpers
branch
from
eb156de
to
b74784f
Compare
appgurueu
force-pushed
the
opt-misc-helpers
branch
from
01ef32d
to
d004b19
Compare
appgurueu
force-pushed
the
opt-misc-helpers
branch
from
d004b19
to
af4caeb
Compare
rubenwardy
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes some misc helpers (particularly formspec escaping which doesn't have to iterate over the string five times anymore). Performance improvement was not tested but I consider this a code quality improvement as well either way.
How to test: Unit tests should still pass.