Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighting of the wield mesh #12341

Merged
merged 2 commits into from
May 20, 2022
Merged

Fix lighting of the wield mesh #12341

merged 2 commits into from
May 20, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented May 17, 2022

Fixes #12338 and removes flicker of wield mesh light when changing current item.

To do

This PR is Ready for Review.

How to test

###Scenario 1

  1. Start any game
  2. Switch time to night
  3. Place a light
  4. Wielded item must be lit near the light and dark far from lights / underground

Scenario 2

  1. Start any game
  2. Switch the current item
  3. Notice that wield mesh changes without becoming black

@x2048
Copy link
Contributor Author

x2048 commented May 17, 2022

@pecksin Can you confirm it fixes #12338 ?

@runsy Will this fix #12180?

@pecksin
Copy link
Contributor

pecksin commented May 18, 2022

@pecksin Can you confirm it fixes #12338 ?

Works. Thanks for the effort!

@x2048 x2048 mentioned this pull request May 18, 2022
Closed
6 tasks
@ghost
Copy link

ghost commented May 19, 2022

@pecksin Can you confirm it fixes #12338 ?

@runsy Will this fix #12180?

No, still the issue.

sfan5
sfan5 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoneWolfHT
Copy link
Contributor

Oh nice, #9441 will probably work after this 👀

@x2048 x2048 merged commit 604fb2b into minetest:master May 20, 2022
@x2048 x2048 deleted the wield_light branch May 20, 2022 20:35
@ghost
Copy link

ghost commented May 21, 2022

Ive close my issue, solved

#12180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wieldhand lighting impacted by night regardless of other factors
4 participants
@x2048 @pecksin @LoneWolfHT @sfan5