Fix lighting of upright_sprite entities #12336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to fix lighting of upright_sprite entities broken in cef252b. Upright sprite entities (icons on drawers or player entity in devtest game) would not take light of the current node into account when shaders are enabled and always be drawn in full brightness.
Example devtest player in a dark cave;
![image](https://user-images.githubusercontent.com/4933697/169604125-e6ac84f5-f259-4d31-bdad-242a6b4a1b40.png)
cef252b removed a call to IMeshSceneNode::setReadOnlyMaterials(true), meaning that materials in IMeshSceneNode would take precedence over the materials of its mesh buffers. GenericCAO::setNodeLight() was still using mesh buffer materials directly.
This PR changes GenericCAO::setNodeLight() to work with IMeshSceneNode materials via getMaterial() call.
To do
This PR is a Ready for Review.
How to test