Fixes to android build. Add option to turn LuaJIT on/off for testing purposes #12334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
approved these changes
May 15, 2022
|
Can you extract the lgc.c change into a separate commit for better change tracking? |
|
Created separate PR: #12347 |
sfan5
reviewed
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12062
Added an annotation to GameActivity.java that is needed to make the Release build work with the newer Android toolchains that have minification.
Added the ability to switch between LuaJIT and PUC Lua. This was helpful for determining where the problem crash was occurring. This includes a fix to lib/lua/src/lgc.c which is needed to prevent a miscompile.