Fix Minetest blaming the wrong mod for errors #12241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Apr 28, 2022
Can you link the code where it does this? |
Sure. Here it is. |
appgurueu
commented
Apr 28, 2022
appgurueu
commented
Apr 28, 2022
rubenwardy
approved these changes
May 9, 2022
sfan5
pushed a commit
that referenced
this pull request
May 12, 2022
Covers the case where mods insert their callbacks manually into "minetest.registered_<callbacks>" (often to achieve a particular order of execution).
sfan5
pushed a commit
that referenced
this pull request
May 12, 2022
Covers the case where mods insert their callbacks manually into "minetest.registered_<callbacks>" (often to achieve a particular order of execution).
sfan5
pushed a commit
that referenced
this pull request
May 14, 2022
Covers the case where mods insert their callbacks manually into "minetest.registered_<callbacks>" (often to achieve a particular order of execution).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably fixes #12236 for the case that mods insert their callbacks manually into minetest.registered_<callbacks> (often to achieve a particular order of execution). This is the case with mesecons and used to be the case with modlib.