Fix some debug info showing despite being disabled in the UI #12205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Apr 21, 2022
sfan5
added
the
Trivial
|
Tested, seems to work: doesn't show when debug is closed. |
It is meant to be available (=allowed) without debug privs for compatibility reasons if and only if the basic debug HUD flag is not explicitly set to false by the modder. If you have the debug priv it will override the HUD flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported by @GoodClover and introduced in #12020, namely here: F5 is now being ignored, only the priv and the flag are used to check whether some debug info (such as GenericCAO hp & armor groups) is shown.