Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSS Color Module Level 4 #12204

Merged
1 commit merged into from
Apr 27, 2022
Merged

Support CSS Color Module Level 4 #12204

1 commit merged into from
Apr 27, 2022

Conversation

appgurueu
Copy link
Contributor

Alternative to #12203. Fixes the link to not point to the dev version as well, but makes Minetest compliant with level 4 by adding the named color "rebeccapurple". See changes from level 3.

@appgurueu appgurueu mentioned this pull request Apr 21, 2022
Merged
@appgurueu appgurueu changed the title Support CSS color module level 4 Support CSS Color Module Level 4 Apr 21, 2022
@appgurueu
Copy link
Contributor Author

Alright, merging the other PR has solved the doc-code mismatch for now. @sfan5 please tag this as "feature" and "low-priority".

@rubenwardy rubenwardy added @ Script API Low priority Feature ✨ PRs that add or enhance a feature labels Apr 24, 2022
@rubenwardy
Copy link
Member

Have you verified that all the colors are in Minetest? Also, conflicts

@rubenwardy rubenwardy added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Apr 24, 2022
@appgurueu
Copy link
Contributor Author

appgurueu commented Apr 24, 2022 •
edited
Loading

Have you verified that all the [named] colors are in Minetest?

Yes.

Also, conflicts

There should be no merge conflicts left.

@rubenwardy
Copy link
Member

image

rubenwardy
rubenwardy reviewed Apr 24, 2022
View reviewed changes
doc/lua_api.txt Outdated Show resolved Hide resolved
@rubenwardy rubenwardy added the Rebase needed The PR needs to be rebased by its author. label Apr 24, 2022
@rubenwardy rubenwardy removed the Rebase needed The PR needs to be rebased by its author. label Apr 24, 2022
@rubenwardy
Copy link
Member

Rebased

@rubenwardy rubenwardy added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Concept approved Approved by a core dev: PRs welcomed! labels Apr 24, 2022
ghost
ghost approved these changes Apr 27, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@ghost ghost merged commit fccf1e2 into minetest:master Apr 27, 2022
appgurueu added a commit to appgurueu/modlib that referenced this pull request Apr 28, 2022
@appgurueu
Support CSS Color Module Level 4 (see minetest/minetest#12204)
3877e33
@appgurueu appgurueu deleted the rebeccapurple branch April 28, 2022 08:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees
No one assigned
Labels
Concept approved Approved by a core dev: PRs welcomed! Feature ✨ PRs that add or enhance a feature Low priority Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ @ Script API Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@appgurueu @rubenwardy