-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add register dialog to separate login/register #12185
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
22244ab
to
8ea7ffd
Compare
Concept: Sounds good, doesn't add an extra step to log in as existing user. UI:
Text:
Code: didn't look yet |
This was something I was experimenting with. The idea is to indicate that it's a navigation rather than an action, as this is usually the difference between links and buttons. This isn't done anywhere else though, and looks out of place, so I'll revert it to a button
See the favourites star next to "Server description" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works other than that.
Maybe not that bright but sure. |
@sfan5 if it were brighter, people would struggle reading the (white) text. If it were gray, it'd resemble an input field. I think this choice is a nice compromise between readability and UX (also considering the whole meh default aspect of formspecs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--> Icon suggestion: greytone + 1 simple stroke to highlight the deletion aspect.
enable_split_login_register = true
:
☑️ Register: empty password + "disallow_empty_password=true" -> "Protocol error"
☑️ Register: normal password
☑️ Login: unknown account -> "Protocol error"
☑️ Login: correct password
☑️ Login: wrong password -> "Protocol error"
enable_split_login_register = false
:
☑️ New account
☑️ Login: correct password
☑️ Login: wrong password -> "Protocol error"
The PR works, but the recent error message changes are definitely not good. PR with a fix is pending (#12378).
New users find Minetest's account system confusing. This change moves username/password to a new dialog, with login and register buttons added to the Join Game tab. The old registration confirmation dialog is removed in favour of the new dialog. Fixes minetest#8138
As discussed on IRC the license info of the icon needs to be noted somewhere. |
Fixes #8138
New users find Minetest's account system confusing. This change moves username/password to a new dialog, with login and register buttons added to the Join Game tab.
The old registration confirmation dialog is removed in favour of the new dialog. Instead of disabling register confirmation, users can completely disable split login/register using
enable_split_login_register = false
To do
How to test
enable_split_login_register = false
behaves as master, but without the register confirmation dialog