Add register dialog to separate login/register

[rubenwardy]

Fixes #8138

New users find Minetest's account system confusing. This change moves username/password to a new dialog, with login and register buttons added to the Join Game tab.

The old registration confirmation dialog is removed in favour of the new dialog. Instead of disabling register confirmation, users can completely disable split login/register using enable_split_login_register = false

To do

• Move delete favourite button to a better location
• Error messages on register from login, and login from register
• What to do when connecting to localhost?

How to test

• Register:
  • Clear minetest.conf. Click register, confirm name field is empty and focused.
  • Fill in information, connect. Confirm server is marked as favourite.
  • Attempt to register on another server, confirm that name is remembered and password is focused
  • Test behaviour when passwords do not match
• Login:
  • Test correct log-in
  • Test attempt to register
  • Test incorrect password
• Test enable_split_login_register = false behaves as master, but without the register confirmation dialog

[sfan5]

Concept: Sounds good, doesn't add an extra step to log in as existing user.

UI:

• Should be no gap between Name + Password
• Blue text vaguely suggests that it is clickable but why is Register not a button?
• It becomes impossible to unfavorite a server 💀

Text:

• "Name not registered" maybe add something like "If you want to join this server for the first time click on 'Register'"
• "Join example.com" -> "Joining example.com:"

Code: didn't look yet

[rubenwardy]

Blue text vaguely suggests that it is clickable but why is Register not a button?

This was something I was experimenting with. The idea is to indicate that it's a navigation rather than an action, as this is usually the difference between links and buttons. This isn't done anywhere else though, and looks out of place, so I'll revert it to a button

It becomes impossible to unfavorite a server skull

See the favourites star next to "Server description"

[sfan5]

See the favourites star next to "Server description"

It needs to actually look like a button for that to be apparent to users.
Also here's an icon suggestion:

[rubenwardy]

Done

[sfan5]

Works other than that.

[rubenwardy]

[sfan5]

Maybe not that bright but sure.
I was actually thinking of gray box and keeping the text orange, but that's just a spontaneous idea.

[Zughy]

@sfan5 if it were brighter, people would struggle reading the (white) text. If it were gray, it'd resemble an input field. I think this choice is a nice compromise between readability and UX (also considering the whole meh default aspect of formspecs)

[SmallJoker]

--> Icon suggestion: greytone + 1 simple stroke to highlight the deletion aspect.

enable_split_login_register = true:

☑️ Register: empty password + "disallow_empty_password=true" -> "Protocol error"
☑️ Register: normal password
☑️ Login: unknown account -> "Protocol error"
☑️ Login: correct password
☑️ Login: wrong password -> "Protocol error"

enable_split_login_register = false:

☑️ New account
☑️ Login: correct password
☑️ Login: wrong password -> "Protocol error"

The PR works, but the recent error message changes are definitely not good. PR with a fix is pending (#12378).

[sfan5]

As discussed on IRC the license info of the icon needs to be noted somewhere.