Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run automated tests when lua files change #12184

Merged
merged 4 commits into from
Apr 30, 2022
Merged

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented Apr 7, 2022

Expands Lua workflow to include:

  • automated testing of devtest game
  • linting of devtest game

Based on conversation in IRC

To do

This PR is Ready for Review.

How to test

  • Github workflows must pass

@x2048 x2048 added @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Apr 7, 2022
@SmallJoker
Copy link
Member

.luacheckrc for devtest is needed too. Here are a few templates for the API names:

@sfan5 sfan5 added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Apr 13, 2022
@x2048
Copy link
Contributor Author

x2048 commented Apr 29, 2022

@sfan5 @SmallJoker I've added .luacheckrc for devtest, so that the job passes now. I guess, fixing the warnings (and removing suppressions from the config file) is a different PR?

@x2048 x2048 removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Apr 29, 2022
@sfan5
Copy link
Member

sfan5 commented Apr 29, 2022

Fine by me to do it in a different PR.

@x2048
Copy link
Contributor Author

x2048 commented Apr 29, 2022

I can merge the PR as soon as it gets approved

@x2048 x2048 merged commit 828461c into minetest:master Apr 30, 2022
@x2048 x2048 deleted the lua_tests branch April 8, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants