Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable shadows by default in devtest #12157

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Enable shadows by default in devtest #12157

merged 3 commits into from
Apr 7, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented Mar 29, 2022 •
edited
Loading

This is to address a problem raised by @NathanSalapat in a comment to #11944.

What's done;

  • Shadow is set to 0.33 for each player that joins
  • /set_lighting command removed
  • /set_shadow command added to control shadow parameters (intensity for now)
  • All code is moved to util_commands mod

To do

This PR is Ready for Review.

How to test

  • Enable shadows in your client
  • Start devtest
  • Game should render with dynamic shadows

@x2048 x2048 added Feature ✨ PRs that add or enhance a feature @ Devtest Game labels Mar 29, 2022
@lhofhansl
Copy link
Contributor

BTW. DevTest already has a chat comment to turn on shadows. Is that not good enough?

@NathanSalapat
Copy link
Contributor

BTW. DevTest already has a chat comment to turn on shadows. Is that not good enough?

What!? Where was that mentioned?

@lhofhansl
Copy link
Contributor

@NathanSalapat It wasn't, but it was part of the #11944 .

@x2048
Copy link
Contributor Author

x2048 commented Mar 31, 2022

@NathanSalapat It's mentioned in How to Test part of #11944

@x2048
Copy link
Contributor Author

x2048 commented Mar 31, 2022

@lhofhansl I forgot about it myself :) This might be an indicator that it's not enough.

@lhofhansl
Copy link
Contributor

We can still merge this one, though. It'll lead to fewer surprises.

@x2048 x2048 changed the title Add a mod to enable shadows to devtest Enable shadows by default in devtest Mar 31, 2022
@x2048 x2048 mentioned this pull request Apr 3, 2022
Merged
4 tasks
@x2048 x2048 merged commit 1348d9a into minetest:master Apr 7, 2022
@x2048 x2048 deleted the shadow_devtest branch April 7, 2022 19:55
x2048 added a commit that referenced this pull request Apr 7, 2022
@x2048
Remove reference to a removed file in devtest (followup to #12157)
3a87fab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 left review comments

Assignees
No one assigned
Labels
@ Devtest Game Feature ✨ PRs that add or enhance a feature >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@x2048 @lhofhansl @NathanSalapat @sfan5