Lua API documentation: Various fixes (2) #12059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
commented
Feb 9, 2022
| v3s16 maxedge = check_v3s16(L, 3); | ||
| v3s16 minp = check_v3s16(L, 2); | ||
| v3s16 maxp = check_v3s16(L, 3); | ||
| sortBoxVerticies(minp, maxp); |
There was a problem hiding this comment.
Sneaky bugfix: Sorting happens in Area::Area(), although this function does not make use of this class to sanitize user input.
appgurueu
reviewed
Feb 11, 2022
SmallJoker
force-pushed
the
documemted
branch
from
d12164c
to
8c82232
Compare
|
Suggestions handled. |
sfan5
reviewed
Feb 14, 2022
sfan5
reviewed
Feb 14, 2022
I took AKryukov92's personally. It put me off and now it's coming finally after 2.5 years.
SmallJoker
force-pushed
the
documemted
branch
from
8c82232
to
b5a7971
Compare
|
(ready for re-review) |
rubenwardy
approved these changes
Feb 23, 2022
|
👍🏾 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collisiontableTo do
This PR is Ready for Review.
How to test