Fix types of get_mapgen_setting_noiseparams #12025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix. Closes #11962, ready for review. Mainmenu noiseparam setting editing still works. @srifqi
Regarding possible breakage:
tonumber
);tonumber
ed the strings, that is a no-op for numbers and works as expected there;The only thing this would break would be actual typechecks for a buggy type or trying to index the number (something like
noiseparams.something:sub(...)
, but I suppose that hardly matters. Should it be found in the wild, it's definitely utter swinecode and on the mod authors, who should be urged to upgrade.Also note that prior to 5.0, said getter would return numbers.