Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply texture pack main menu textures immediately #12018

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Apply texture pack main menu textures immediately #12018

merged 2 commits into from
Feb 12, 2022

Conversation

rollerozxa
Copy link
Member

This PR makes texture pack main menu textures apply immediately after being enabled. Previously it would only take effect after restarting Minetest.

To do

This PR is Ready for Review.

How to test

  1. Apply the changes in this PR, and install this texture pack for testing.
  2. Open Minetest and enable the texture pack. This should make the main menu immediately switch to the texture pack's textures.
  3. Disable the texture pack. It should immediately switch back to the default textures and the built-in sky background.

ghost
ghost suggested changes Feb 2, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the buttons work, but you'll need something similar for handle_doubleclick or else double-clicking a texture pack will change the pack without updating the menu theme

@ghost ghost added @ Client / Audiovisuals Action / change needed Code still needs changes (PR) / more information requested (Issues) Feature ✨ PRs that add or enhance a feature Concept approved Approved by a core dev: PRs welcomed! labels Feb 2, 2022
@rollerozxa
Copy link
Member Author

Forgot that is a thing too... >.>

Fixed, please review again.

ghost
ghost approved these changes Feb 4, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ghost ghost added One approval ✅ ◻️ and removed Action / change needed Code still needs changes (PR) / more information requested (Issues) labels Feb 4, 2022
SmallJoker
SmallJoker approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@SmallJoker SmallJoker merged commit 258ae99 into minetest:master Feb 12, 2022
LoneWolfHT pushed a commit to LoneWolfHT/minetest that referenced this pull request Mar 17, 2022
@rollerozxa @LoneWolfHT
Apply texture pack main menu textures immediately (minetest#12018)
b55ae1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
@ Client / Audiovisuals Concept approved Approved by a core dev: PRs welcomed! Feature ✨ PRs that add or enhance a feature >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rollerozxa @SmallJoker