Update and improve warnings when no games are found or when only devtest is installed

[rollerozxa]

This PR updates the warning messages that appear when either no game is installed or when only the Development Test game is found. Previously it would give an unclear message to "download one from minetest.net", but now it contains a button which takes you to ContentDB in-game where you can actually install a new game.

To do

This PR is a Ready for Review.

How to test

• Test with only Development Test installed and try to click on the "Install another game" button. It should take you to ContentDB where you can install a game.
• Test with no game installed at all and try to click on the "Install a game" button. It should take you to ContentDB where you can install a game.
• Test that the regular create world dialog still works like it should without any regressions.

[sfan5]

Not this:delete()?

[rollerozxa]

this:delete() causes this:

While this:hide() works like it should. It's also used by dlg_config_world when opening up the ContentDB dialog so I just copied that.

[rubenwardy]

The current code will return to new world after installing the game, I think that's fine

One thing to note is that the game theme isn't applied when doing this

[ghost]

Did a quick test and saw something a bit problematic:

If you try to use this feature from Devtest as prompted in your "how to test" list it lets you go install a game. However, after the install is finished it takes you back to the new world dialog for devtest, without the devtest warning. Worse, since we have a game installed already the warning message is gone. I think the resulting flow is confusing, we should either go back to the main menu or change the active game in response (the former is probably simpler to do).

[ghost]

One other thing I noticed in this test: We have a bug where the game selection list is shown in the new world dialog but only when devtest is your only installed game. This is not a regression from your code so it shouldn't block this PR though, it's a bug in 4c8c649.

[sfan5]

We have a bug where the game selection list is shown in the new world dialog but only when devtest is your only installed game. This is not a regression from your code so it shouldn't block this PR though, it's a bug in 4c8c649.

That's an intentional "limitation", I didn't want to figure out layout heights for all combinations of devtest_only={true,false} + hide_gamelist={true,false}.

[ghost]

That's an intentional "limitation", I didn't want to figure out layout heights for all combinations of devtest_only={true,false} + hide_gamelist={true,false}.

I see. I feel like it ought to be done at some point, but it's low priority and doesn't affect this PR so I won't comment on that further.

[rollerozxa]

If you try to use this feature from Devtest as prompted in your "how to test" list it lets you go install a game. However, after the install is finished it takes you back to the new world dialog for devtest, without the devtest warning. Worse, since we have a game installed already the warning message is gone. I think the resulting flow is confusing, we should either go back to the main menu or change the active game in response (the former is probably simpler to do).

In addition to this it also becomes ambiguous what game you're creating a world for if you have no games installed, go to CDB, install several games and then go back. Plus as rubenwardy mentioned the game theme doesn't become applied when going back.

So yeah it should just go back to the main menu, it'd be better that way.

[rubenwardy]

Are you stuck on this?

[rollerozxa]

yeah, was never able to figure out how to go back to the main menu as opposed to the new world dialog. help would be appreciated

[sfan5]

LGTM