Fix NodeDef backwards compatibility to 5.3.0 #11942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixes crashes on older clients when [png is used as base image 2. Fixes liquid type assertion fails on debug builds
sfan5
reviewed
Jan 8, 2022
sfan5
reviewed
Jan 8, 2022
|
Where is @hecktest ? |
sfan5
approved these changes
Jan 9, 2022
LoneWolfBT
pushed a commit
to MT-CTF/minetest
that referenced
this pull request
Feb 13, 2022
1. Fixes crashes on older clients when [png is used as base image 2. Fixes liquid type assertion fails on debug builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pngis used as base imageBoth reported in #10737 (comment), whereas (1) is the original crash cause.
To do
This PR is Ready for Review.
How to test
assert(liquid_type == LIQUID_SOURCE);FATAL_ERROR_IF(liquid_type != LIQUID_SOURCE,"a");assert(liquid_type == LIQUID_FLOWING);FATAL_ERROR_IF(liquid_type != LIQUID_FLOWING,"b");