Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing zstd-libs to final Docker image #11596

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Add missing zstd-libs to final Docker image #11596

merged 2 commits into from
Sep 7, 2021

Conversation

BuckarooBanzay
Copy link
Contributor

@BuckarooBanzay BuckarooBanzay commented Sep 7, 2021

The generated docker image does not currently work because of a missing zstd dependency in the final layer.
It fails since #10788

Error message:

Error loading shared library libzstd.so.1: No such file or directory (needed by /usr/local/bin/minetestserver)
Error relocating /usr/local/bin/minetestserver: ZSTD_initCStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_compressStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_freeCStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_createDStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_decompressStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_initDStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_createCStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_isError: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_freeDStream: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_getErrorName: symbol not found
Error relocating /usr/local/bin/minetestserver: ZSTD_endStream: symbol not found

This PR adds:

  • the zstd-libs to the final layer
  • the minetestserver --version command after the docker build to verify it

How to test

docker build . -t minetest
docker run --rm -it minetest

The usual minetest banner should pop up afterwards

@sfan5 sfan5 added Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Sep 7, 2021
@sfan5 sfan5 changed the title add zstd-libs to final docker image [trivial] Add missing zstd-libs to final Docker image Sep 7, 2021
@sfan5
Copy link
Member

sfan5 commented Sep 7, 2021

Can you add a command that runs minetestserver --version inside the built Docker container (is that possible?) to the CI job so this doesn't happen again?

@BuckarooBanzay
Copy link
Contributor Author

Can you add a command that runs minetestserver --version inside the built Docker container (is that possible?) to the CI job so this doesn't happen again?

done 👍 seems to work

@sfan5 sfan5 merged commit bcb6565 into minetest:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants