Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GUIEditBoxWithScrollBar using a smaller small-/largeStep than intlGUIEditBox #11519

Merged
merged 3 commits into from
Aug 8, 2021
Merged

Fix GUIEditBoxWithScrollBar using a smaller small-/largeStep than intlGUIEditBox #11519

merged 3 commits into from
Aug 8, 2021

Conversation

Desour
Copy link
Member

@Desour Desour commented Aug 7, 2021

  • It just set small- and large_step of its scrollbar to 1.
  • This caused textarea[] formspec elements to scroll horribly slow with the mouse wheel.
  • The code is taken from intlGUIEditBox.cpp, to make it consistent.
  • This is a bugfix.
  • This bug is really annoying and not new. Everyone is experiencing it at least since we switched to minetest's own irrlicht fork, but the bug is older (5 years, github says).

To do

This PR is a Ready for Review.

How to test

  • Open a formspec with a textarea, eg. the one of a mesecons luacontroller.
  • Make sure it has a scrollbar (ie. write multiple lines of text to make it appear).
  • Use your mouse wheel to scroll. It should no longer be horribly slow.

@Desour
Fix GUIEditBoxWithScrollBar using a smaller small-/largeStep than int…
6e36e72 
…lGUIEditBox

* It just set small- and large_step of its scrollbar to 1.
* This caused textarea[] formspec elements to scroll horribly slow with the mouse wheel.
@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label Aug 7, 2021
SmallJoker
SmallJoker approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmallJoker SmallJoker merged commit 1ab29f1 into minetest:master Aug 8, 2021
@Desour Desour deleted the fix_guieditboxwithscrollbar_stepsizes branch August 8, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rob v-rob v-rob left review comments

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Desour @sfan5 @SmallJoker @v-rob