Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bold, italic and monospace font styling for HUD text elements #11478

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Add bold, italic and monospace font styling for HUD text elements #11478

merged 5 commits into from
Jul 27, 2021

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Jul 23, 2021 •
edited
Loading

Redo of #11022 with:

  • Monospace support
  • No pointless bool type
  • Devtest testing mod (base by @celeron55)

To do

This PR is Ready for Review.

How to test

  1. devtest
  2. /hudfonts with optional number argument

@sfan5 sfan5 added @ Script API Feature ✨ PRs that add or enhance a feature labels Jul 23, 2021
@sfan5 sfan5 changed the title Add bold, italic and monospace supprot for HUD text elements Add bold, italic and monospace font styling for HUD text elements Jul 23, 2021
hecktest
hecktest approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@hecktest hecktest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything.

@v-rob v-rob requested review from v-rob and removed request for v-rob July 27, 2021 04:41
@sfan5 sfan5 merged commit 6e8aebf into minetest:master Jul 27, 2021
@sfan5 sfan5 deleted the hud_font_style branch July 27, 2021 17:11
@AFCMS AFCMS mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecktest hecktest hecktest approved these changes

Assignees
No one assigned
Labels
Feature ✨ PRs that add or enhance a feature One approval ✅ ◻️ @ Script API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @hecktest @LizzyFleckenstein03