Add helpful error messages if Irrlicht library or include dir are set incorrectly #11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
the
Maintenance
SmallJoker
reviewed
Apr 26, 2021
SmallJoker
reviewed
Apr 26, 2021
| mark_as_advanced(CLEAR IRRLICHT_LIBRARY IRRLICHT_INCLUDE_DIR) | ||
| # Handholding for users | ||
| if(IRRLICHT_INCLUDE_DIR AND (NOT IS_DIRECTORY "${IRRLICHT_INCLUDE_DIR}" OR | ||
| NOT EXISTS "${IRRLICHT_INCLUDE_DIR}/irrlicht.h")) |
There was a problem hiding this comment.
Do we also apply that code style to cmake?
There was a problem hiding this comment.
Good question actually 🤷
well, it's nitpicking, so just keep it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11231, #11218
These changes work "indirectly", by removing the path if it's set incorrectly the build process will not proceed and the user informed directly that something isn't right.
To do
This PR is Ready for Review.
How to test
IRRLICHT_INCLUDE_DIRto a file, observe error messageIRRLICHT_INCLUDE_DIRto a directory that doesn't contain irrlicht.h, observe error messageIRRLICHT_LIBRARYto a directory, observe error messageIRRLICHT_LIBRARYto anything that's not a library, observe error message