Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize more guiEditBoxes code #10789

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Factorize more guiEditBoxes code #10789

merged 3 commits into from
Jan 13, 2021

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Jan 8, 2021

Add compact, short information about your PR for easier understanding:

  • Reduce duplicated code between editBoxes in our code

To do

This PR is Ready for Review.

How to test

Run code with various editboxes, all should work as intended

SmallJoker
SmallJoker reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

src/gui/guiEditBox.cpp Outdated Show resolved Hide resolved
src/gui/guiEditBox.cpp Outdated Show resolved Hide resolved
@nerzhul nerzhul merged commit 4b01282 into minetest:master Jan 13, 2021
@nerzhul nerzhul deleted the refacto/factorize_guieditbox branch January 13, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker left review comments

@sfan5 sfan5 Awaiting requested review from sfan5

Assignees
No one assigned
Labels
@ Client / Controls / Input One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nerzhul @SmallJoker