Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local tab: rename 'Configure' to 'Select Mods' #10779

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Jan 4, 2021

Closes #8243

People were debating between Select Mods and World Mods, it's kind of a 50-50. I think the latter is better but I honestly don't care, both are better than Configure

To do

This PR is Ready for Review.

How to test

Launch the engine (but you really don't have to)

@Andrey2470T
Copy link
Contributor

As this section aims only with mods I would rather to rename it to like "Configure Mods" to be more clear.

@appgurueu
Copy link
Contributor

As this section aims only with mods I would rather to rename it to like "Configure Mods" to be more clear.

It should be named "select (world) mods" to be clear as to what the user can achieve through it: They can select a set of mods for their world. "Configure" is misleading as it suggests world configuration; "Configure Mods" IMO implies configuration and not selection of mods (as done in minetest.conf).

@Andrey2470T
Copy link
Contributor

As this section aims only with mods I would rather to rename it to like "Configure Mods" to be more clear.

It should be named "select (world) mods" to be clear as to what the user can achieve through it: They can select a set of mods for their world. "Configure" is misleading as it suggests world configuration; "Configure Mods" IMO implies configuration and not selection of mods (as done in minetest.conf).

IMO it should be clear for users. Configuration mods means enabling/disabling mods, i.e. selecting out a certain set of mods. To be honest, I`m neutral about the election of more correct name, because "Select Mods" is not bad phrase, either.

@sfan5 sfan5 added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jan 18, 2021
@rubenwardy rubenwardy changed the title Local tab: rename 'Configure' to 'World Mods' Local tab: rename 'Configure' to 'Select Mods' Jan 20, 2021
@rubenwardy rubenwardy merged commit eb8af61 into minetest:master Jan 20, 2021
@Zughy Zughy deleted the select_mods branch June 3, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Mainmenu Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Configure" button to a less ambiguous name
5 participants