Implement mapblock camera offset correctly #10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Dec 5, 2020
sfan5
reviewed
Dec 5, 2020
|
Looks good... Tested... Works.... |
Co-authored-by: sfan5 <[email protected]>
Co-authored-by: sfan5 <[email protected]>
|
No behaviour change for attachments either. Works well. |
HybridDog
pushed a commit
to HybridDog/minetest
that referenced
this pull request
Dec 17, 2020
Implement mapblock camera offset correctly - reduce client jitter Co-authored-by: hecktest <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix, rendering, performance, maintenance, trivial
The camera offset for mapblocks was originally implemented in a really stupid way, see #10683 (comment)
This PR reimplements it as a matrix transformation instead of translating every damn vertex in software.
I also moved a couple struct types to the header where they belong.
How to test
Zip around the map with fly/fast to trigger the camera offset repeatedly. Enjoy reduced mesher stutter.
Teleport to the map's edge to verify that nothing is jittery.