Removed some obsolete code #10562
Merged
Removed some obsolete code #10562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
reviewed
Oct 26, 2020
Zughy
commented
Oct 26, 2020
|
This is what I meant by "obsolete means it's already gone": It often doesn't make sense to remove all traces of a gone feature (such as compatibility warnings) |
sfan5
reviewed
Oct 26, 2020
sfan5
added
the
Maintenance
nerzhul
requested changes
Oct 27, 2020
SmallJoker
reviewed
Dec 18, 2020
rubenwardy
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more, but it covers classes I'd like to understand better before cleaning them up. Took inspiration from #9062
I changed
register_on_auth_failfrom obsolete to deprecated, as it appears on the api as suchTo do
This PR is Ready for Review.
How to test
check the code