Fix float argument check in minetest.set_timeofday() #10483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid an engine assumption crash
I've changed the check, now it doesn't make the whole client crash anymore (only the game)
closes Many Lua C functions are missing type checks #1794 (I've tried all the listed functions, they crash as intended except
set_timeofday
)I guess there are other functions that might not work as intended with weird values, but testing them all is a suicide. I suggest to solve them on the go, avoiding keeping an issue open - especially because the listed ones are all solved
To do
This PR is Ready for Review.
How to test
Make it crash with