Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wclass-memaccess only called when GCC > 7 #10453

Merged
merged 1 commit into from
Oct 6, 2020
Merged

-Wclass-memaccess only called when GCC > 7 #10453

merged 1 commit into from
Oct 6, 2020

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Oct 2, 2020 •
edited
Loading

-Wclass-memaccess was implemented in GCC 8. This avoids a warning if GCC version is 7 or lesser. First time touching #ifs, I hope I did it correctly

To do

This PR is Ready for Review.

How to test

Compile it having GCC < 8 and it shouldn't throw a warning anymore

@Zughy Zughy changed the title -Wmem-access only called when GCC > 7 -Wclass-memaccess only called when GCC > 7 Oct 2, 2020
@sfan5 sfan5 added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Oct 2, 2020
@Desour Desour mentioned this pull request Oct 2, 2020
Merged
@SmallJoker SmallJoker merged commit a37e96e into minetest:master Oct 6, 2020
@Zughy Zughy deleted the zughy_gcc branch October 9, 2020 20:54
JosiahWI pushed a commit to JosiahWI/minetest that referenced this pull request Oct 17, 2020
@Zughy @JosiahWI
-Wmem-access only called when GCC > 7 (minetest#10453)
4172cb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zughy @rubenwardy @sfan5 @SmallJoker